Better handle missing ostruct#857
Merged
Merged
Conversation
In the Ruby test suite, this test class is causing trouble because ostruct is not available. Having an autoload for JSON::GenericObject but causing it not to define the constant causes a warning. See 0dc1cd407e7775610f2bcaef6c1282369867f91c and caa5d8cdd7483647013af5e3d1701b0ed3ec8785 in ruby. We can skip defining the test class entirely instead when ostruct is not available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Ruby test suite, this test class is causing trouble because ostruct is not available. Having an autoload for
JSON::GenericObjectbut causing it not to define the constant causes a warning.See ruby/ruby@0dc1cd4 and ruby/ruby@caa5d8c in ruby.
We can skip defining the test class entirely instead when ostruct is not available.